Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploads Paparazzi screenshots to Emerge. #2232

Merged
merged 8 commits into from
Mar 18, 2025
Merged

Uploads Paparazzi screenshots to Emerge. #2232

merged 8 commits into from
Mar 18, 2025

Conversation

JayShortway
Copy link
Member

@JayShortway JayShortway commented Mar 7, 2025

This is a transformation of #2214.

Description

We have quite a few Paparazzi tests from pre-Emerge. This PR uploads them to Emerge to verify them. They are still rendered by Paparazzi.

Note: The Emerge comment complains that the base build is not found. I'm assuming that is referring to the base of the Paparazzi snapshots. My idea is to merge this, see if it starts working in subsequent PRs, and revert if not. Emerge is processing the snapshots fine:

Motivation

Accepting new screenshots as the golden variant is 1 click on Emerge, while previously it took multiple commands and an extra PR.

@JayShortway JayShortway self-assigned this Mar 7, 2025
Copy link

emerge-tools bot commented Mar 7, 2025

📸 Snapshot Test

Base build not found

No build was found for the base commit 18af3ba. This is required to generate a snapshot diff for your pull request.

It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve.


🛸 Powered by Emerge Tools

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.28%. Comparing base (18af3ba) to head (c4cbf35).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2232   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files         278      278           
  Lines        9484     9484           
  Branches     1336     1336           
=======================================
  Hits         7614     7614           
  Misses       1310     1310           
  Partials      560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JayShortway JayShortway requested a review from a team March 14, 2025 14:40
@JayShortway JayShortway marked this pull request as ready for review March 14, 2025 14:40
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo much easier with this 🙌 Thank you so much for doing this! Left a comment that I think could clean that up a bit, but not a blocker.

@@ -155,6 +155,28 @@ commands:
- android/save-gradle-cache
- android/save-build-cache

install-ruby:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good idea, TIL! However unfortunately I get this error when installing the Emerge CLI:

ERROR:  While executing gem ... (Gem::Exception)
    OpenSSL is not available. Install OpenSSL and rebuild Ruby or use non-HTTPS sources (Gem::Exception)
        <stack trace>

Exited with code exit status 1

So I guess I'll revert and use the manually-written step for now.

@@ -517,21 +539,6 @@ jobs:
- store_test_results:
path: ~/gsutil/

verify_debug_view_snapshot_tests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@JayShortway
Copy link
Member Author

Bypassing rules only for Emerge Snapshot Test and verify-revenuecatui-snapshots, as those are expected to fail in this PR. Will update the required checks now.

@JayShortway JayShortway merged commit ac736d7 into main Mar 18, 2025
12 of 13 checks passed
@JayShortway JayShortway deleted the paparazzi-emerge branch March 18, 2025 12:15
This was referenced Mar 19, 2025
vegaro pushed a commit that referenced this pull request Mar 19, 2025
**This is an automatic release.**

## RevenueCatUI SDK
### 🐞 Bugfixes
* Fix landscape mode in Paywalls v1 Template 3 (#2265) via Josh Holtz
(@joshdholtz)
### Customer Center
#### ✨ New Features
* feat: Introduce `CustomerCenterView` for hybrid usage (#2170) via
Cesar de la Vega (@vegaro)
* Add `onManagementOptionSelected` to `CustomerCenterListener` (#2270)
via Cesar de la Vega (@vegaro)
### Paywallv2
#### 🐞 Bugfixes
* [Paywalls V2] Ignores missing font alias if it's blank. (#2271) via
JayShortway (@JayShortway)
* [Paywalls V2] Fixes badges not being overriden (#2266) via JayShortway
(@JayShortway)

### 🔄 Other Changes
* [Diagnostics] Add play_store_version and play_services_version to all
google events (#2269) via Toni Rico (@tonidero)
* [Diagnostics] Add `id` and `app_session_id` to events (#2268) via Toni
Rico (@tonidero)
* Uploads Paparazzi screenshots to Emerge. (#2232) via JayShortway
(@JayShortway)

Co-authored-by: revenuecat-ops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants