Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: EventsManagerIntegrationTests working as expected #4862

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

facumenzella
Copy link
Contributor

@facumenzella facumenzella commented Mar 10, 2025

Motivation

We need to be sure events are working as expected =)

Description

I've tweaked the test to just call Purchases api. The only caveat is that the tracking for customer center async, and the one for paywalls is not, so I had to add an arbitrary sleep. Once this is merged, I can go with #4837

This will enable further refactors for PaywallEventsManager, like renaming it to support FeatureEvent
Test is only ignored in the offline test plan

@facumenzella
Copy link
Contributor Author

@RCGitBot please test

@facumenzella facumenzella requested a review from a team March 10, 2025 12:16
@facumenzella
Copy link
Contributor Author

@RCGitBot please test

Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More testing is more better! Just a comment on reducing the risk of flakiness.

@facumenzella
Copy link
Contributor Author

@RCGitBot please test

@facumenzella facumenzella merged commit 9d6cdd8 into main Mar 11, 2025
10 checks passed
@facumenzella facumenzella deleted the chore/re-enable-test branch March 11, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants