Fix paywall footer dismissal crash #1120
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
approved these changes
Oct 30, 2024
JayShortway
approved these changes
Oct 30, 2024
Comment on lines
+28
to
+30
| // It's possible the view has been detached at this point which can cause issues | ||
| // since the viewModel is not available anymore. We don't really need to remeasure | ||
| // in this case. |
5 tasks
JayShortway
pushed a commit
that referenced
this pull request
Nov 1, 2024
**This is an automatic release.** ## RevenueCat SDK ### 📦 Dependency Updates * Bump rexml from 3.3.6 to 3.3.9 in /examples/purchaseTesterTypescript (#1115) via dependabot[bot] (@dependabot[bot]) * Bump cocoapods from 1.15.2 to 1.16.1 (#1119) via dependabot[bot] (@dependabot[bot]) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 13.7.0 (#1118) via RevenueCat Git Bot (@RCGitBot) * [iOS 5.7.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.7.0) * Bump danger from 9.5.0 to 9.5.1 (#1112) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.224.0 to 2.225.0 (#1111) via dependabot[bot] (@dependabot[bot]) ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix paywall footer dismissal crash (#1120) via Toni Rico (@tonidero) --------- Co-authored-by: RevenueCat CI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #994
Basically when the footer is dismissed within the same view, it triggers a new layout, which since we call a remeasurement with a
postcall, this remeasurement may happen after the view has been removed from the window. This view requires access to the context to be able to obtain theViewModelin the underlying composable, causing a crash.