Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explicit support for WHATWG URLs #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: add explicit support for WHATWG URLs
It seems the library is already compatible with WHATWG URLs, this commit is only updating tests and documentation to reflect that.
aduh95 authored Feb 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 1a3117baa39b09e4d37d8e8d94106d169247fd81
1 change: 1 addition & 0 deletions test.js
Original file line number Diff line number Diff line change
@@ -92,6 +92,7 @@ describe('getProxyForUrl', function() {
testProxyUrl(env, '', 'https://example');
testProxyUrl(env, 'http://http-proxy', 'http://example');
testProxyUrl(env, 'http://http-proxy', parseUrl('http://example'));
testProxyUrl(env, 'http://http-proxy', new URL('http://example'));

// eslint-disable-next-line camelcase
env.http_proxy = 'http://priority';