Add services to return Action interface details #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new rosapi services to return typedef details for action interfaces (goal, result, and feedback) by implementing helper functions and corresponding service endpoints.
- Added helper functions in objectutils.py to recursively retrieve typedefs for action goal, result, and feedback messages.
- Updated the rosapi_node script to register new services (ActionGoalDetails, ActionResultDetails, and ActionFeedbackDetails) with their handling functions.
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rosapi/src/rosapi/objectutils.py | Added functions to recursively retrieve typedefs for action interfaces. |
| rosapi/scripts/rosapi_node | Registered and implemented new services for action typedef details. |
Files not reviewed (4)
- rosapi_msgs/CMakeLists.txt: Language not supported
- rosapi_msgs/srv/ActionFeedbackDetails.srv: Language not supported
- rosapi_msgs/srv/ActionGoalDetails.srv: Language not supported
- rosapi_msgs/srv/ActionResultDetails.srv: Language not supported
bjsowa
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
Added the following
rosapiservices:~/action_goal_details~/action_result_details~/action_feedback_detailsDescription
Added services to
rosapito retrieve details on action interfaces, similar to the existing message and request services.