fix: incompatible QoS settings for subs

[Egoless41]

for reliability, if any subscribed topic has a non-reliable policy, we set reliability to best effort. for durability, if if any subscribed topic has a non-transient-local policy, we set durability to volatile.

Public API Changes
None

Description
for reliability, if any subscribed topic has a non-reliable policy, we set reliability to best effort. for durability, if if any subscribed topic has a non-transient-local policy, we set durability to volatile.

Fix for #1022

[bjsowa]

for reliability, if any subscribed topic has a non-reliable policy, we set reliability to best effort

This is already the case. It is exactly what this line does:

        if any(pub.qos_profile.reliability == ReliabilityPolicy.BEST_EFFORT for pub in infos):
            qos.reliability = ReliabilityPolicy.BEST_EFFORT

for durability, if if any subscribed topic has a non-transient-local policy, we set durability to volatile.

so in other words, we set transient local policy if all publishers on that topic also use transient local policy. Wouldn't it be easier if you just modified this line:

        if any(pub.qos_profile.durability == DurabilityPolicy.TRANSIENT_LOCAL for pub in infos):

by changing any to all ?

[Egoless41]

Tests facing same problem with my issue:

[rosbridge_websocket-1] [WARN] [1743686946.443985423] [rosbridge_websocket]: New publisher discovered on topic '/a_topic', offering incompatible QoS. No messages will be received from it. Last incompatible policy: DURABILITY
'''