Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Close SortDropdown on sort select #1224

Closed
wants to merge 2 commits into from
Closed

[FIX] Close SortDropdown on sort select #1224

wants to merge 2 commits into from

Conversation

Prateek93a
Copy link
Contributor

@RocketChat/ReactNative

Closes #1222

With this bug fix, after hitting the sort by alphabet button or sort by activity button, the SortDropdown will also close along with sorting

diegolmello
diegolmello requested changes Sep 24, 2019
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this PR contains changes you made on React.Fragment.

@diegolmello diegolmello changed the title Close Sortdropdwon bug fix [FIX] Close SortDropdown on sort select Sep 24, 2019
@Prateek93a
Copy link
Contributor Author

Ok, I will fix my code

@Prateek93a Prateek93a mentioned this pull request Sep 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello requested changes

Assignees
No one assigned
Labels
🛠 fix 🚨 needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Close SortDropdown on sort select
2 participants
@Prateek93a @diegolmello