Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta #1912

Closed
wants to merge 104 commits into from
Closed

Beta #1912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
104 commits
Select commit Hold shift + click to select a range
8c44d9c
[NEW] Custom Status
djorkaeffalexandre Mar 2, 2020
cd25daa
[FIX] Subscribe to changes
djorkaeffalexandre Mar 3, 2020
3d4a818
[FIX] Improve code using Banner component
djorkaeffalexandre Mar 3, 2020
4557279
[IMPROVEMENT] Toggle modal
djorkaeffalexandre Mar 3, 2020
062c4a3
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
djorkaeffalexandre Mar 3, 2020
a15492f
[NEW] Edit custom status from Sidebar
djorkaeffalexandre Mar 3, 2020
ed9472c
[FIX] Modal when tablet
djorkaeffalexandre Mar 3, 2020
055ca50
[FIX] Styles
djorkaeffalexandre Mar 3, 2020
85900f5
[FIX] Switch to react-native-promp-android
djorkaeffalexandre Mar 3, 2020
f88614a
Merge develop
djorkaeffalexandre Mar 3, 2020
572dac1
Merge develop
djorkaeffalexandre Mar 4, 2020
5d09b91
[FIX] Custom Status UI
djorkaeffalexandre Mar 4, 2020
712e3c3
[TESTS] E2E Custom Status
djorkaeffalexandre Mar 4, 2020
838f666
[WIP] Reopen without timeOut & ping with 5 sec & Fix Unsubscribe
djorkaeffalexandre Mar 11, 2020
2de060c
[FIX] Remove duplicated close
djorkaeffalexandre Mar 11, 2020
9308eab
[FIX] Use no-dist lib
djorkaeffalexandre Mar 13, 2020
b629e57
[FIX] Try minor fix
djorkaeffalexandre Mar 16, 2020
11b2117
[FIX] Try reopen connection when app was put on foreground
djorkaeffalexandre Mar 17, 2020
b4d70b7
[FIX] Remove timeout
djorkaeffalexandre Mar 17, 2020
f985160
[FIX] Build
djorkaeffalexandre Mar 17, 2020
8dd4ebe
[FIX] Patch
djorkaeffalexandre Mar 17, 2020
093bd05
[FIX] Snapshot
djorkaeffalexandre Mar 17, 2020
d996455
[IMPROVEMENT] Decrease time to reopen
djorkaeffalexandre Mar 17, 2020
0abbf73
[FIX] Some fixes
djorkaeffalexandre Mar 19, 2020
761bee6
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
djorkaeffalexandre Mar 19, 2020
fbfc77e
[FIX] Update sdk version
djorkaeffalexandre Mar 19, 2020
db426e0
[FIX] Subscribe Room Once
djorkaeffalexandre Mar 19, 2020
5ba4845
[CHORE] Update sdk
djorkaeffalexandre Mar 19, 2020
89bc5bf
[FIX] Subscribe Room
djorkaeffalexandre Mar 19, 2020
ca09e93
[FIX] Try to resend missed subs
djorkaeffalexandre Mar 19, 2020
245c93c
[FIX] Users never show status when start app without network
djorkaeffalexandre Mar 20, 2020
2bd622a
[FIX] Subscribe to room
djorkaeffalexandre Mar 20, 2020
c9dbacc
Create updateLastOpen param on readMessages
diegolmello Mar 20, 2020
cd82f9a
Remove InteractionManager from load messages
diegolmello Mar 20, 2020
40abc98
[FIX] Multiple servers
djorkaeffalexandre Mar 20, 2020
1adc2d5
[CHORE] Update SDK
djorkaeffalexandre Mar 20, 2020
59a8645
Merge branch 'develop' into test.sdk-disconnect
diegolmello Mar 20, 2020
2362820
Merge branch 'develop' into fix.last-open
diegolmello Mar 20, 2020
d018db3
Merge branch 'fix.last-open' into beta
diegolmello Mar 20, 2020
c2d7b68
Merge branch 'develop' into new.custom-status-ui
diegolmello Mar 20, 2020
7a80e70
Fix banner
diegolmello Mar 20, 2020
59823ca
[FIX] Don't duplicate streams on subscribeAll
djorkaeffalexandre Mar 20, 2020
83ff1d0
Fix banner
diegolmello Mar 23, 2020
527bdcc
Fix subtitle
diegolmello Mar 23, 2020
ede6ffd
status text
diegolmello Mar 23, 2020
0d1c787
Fix topic header
diegolmello Mar 23, 2020
1e61167
Fix RoomActionsView topic
diegolmello Mar 23, 2020
033bcbf
Merge branch 'develop' into new.custom-status-ui
diegolmello Mar 23, 2020
b6b936f
[FIX] Server version when start the app offline
djorkaeffalexandre Mar 23, 2020
90f0a62
[FIX] Server version cached
djorkaeffalexandre Mar 23, 2020
0d1ea0d
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
djorkaeffalexandre Mar 23, 2020
a416ee9
[CHORE] Remove unnecessary code
djorkaeffalexandre Mar 23, 2020
f57d6f9
Fix header alignment on Android
diegolmello Mar 24, 2020
5e3d1e3
Merge branch 'develop' into beta
diegolmello Mar 24, 2020
9c575b6
Merge branch 'test.sdk-disconnect' into beta
diegolmello Mar 24, 2020
cb4a3f8
[FIX] Offline server version
djorkaeffalexandre Mar 24, 2020
1cfe72f
Merge branch 'new.custom-status-ui' into beta
diegolmello Mar 24, 2020
fe30e26
[FIX] Subscribe before connect
djorkaeffalexandre Mar 24, 2020
8abd36b
[FIX] Remove unncessary props
djorkaeffalexandre Mar 24, 2020
63655ac
Merge branch 'test.sdk-disconnect' into beta
diegolmello Mar 24, 2020
19423a1
[FIX] RoomInfo crashes when without statusText
djorkaeffalexandre Mar 24, 2020
fc41723
[FIX] Use users.setStatus
djorkaeffalexandre Mar 24, 2020
059e45a
[FIX] Remove customStatus of ProfileView
djorkaeffalexandre Mar 24, 2020
f48434a
Merge branch 'develop' into beta
diegolmello Mar 26, 2020
36f5a06
Merge branch 'new.custom-status-ui' into beta
diegolmello Mar 26, 2020
07b2b32
[FIX] Room View Thread Header
djorkaeffalexandre Mar 26, 2020
e695a83
Onboarding texts
diegolmello Mar 26, 2020
c876ddb
[FIX] Update sdk
djorkaeffalexandre Mar 26, 2020
2384ba2
OnboardingView
diegolmello Mar 26, 2020
8dfd257
Merge branch 'develop' into beta
diegolmello Mar 26, 2020
16d90e6
Merge branch 'test.sdk-disconnect' into beta
diegolmello Mar 26, 2020
0278bae
Merge branch 'new.custom-status-ui' into beta
diegolmello Mar 26, 2020
4253840
FormContainer
diegolmello Mar 26, 2020
c796df2
Minor fixes
diegolmello Mar 26, 2020
abf1c0f
NewServerView
diegolmello Mar 26, 2020
9a3319b
Remove code
diegolmello Mar 26, 2020
238ceb8
Refactor
diegolmello Mar 26, 2020
50e7d7d
WorkspaceView
diegolmello Mar 26, 2020
f0408b3
Stash
diegolmello Mar 26, 2020
09ef565
Login with email working
diegolmello Mar 27, 2020
d05dc50
Login with
diegolmello Mar 27, 2020
2ec8e85
Join open
diegolmello Mar 27, 2020
4530a82
[FIX] User status & Unsubscribe Typing
djorkaeffalexandre Mar 27, 2020
479270d
Revert "Login with"
diegolmello Mar 27, 2020
43a8907
Fix create account styles
diegolmello Mar 27, 2020
4a55277
[FIX] Typing at incorrect room
djorkaeffalexandre Mar 27, 2020
d2f90eb
[FIX] Multiple Servers
djorkaeffalexandre Mar 27, 2020
e541fcf
Register
diegolmello Mar 27, 2020
c7c7c38
Refactor
diegolmello Mar 27, 2020
c40800d
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
djorkaeffalexandre Mar 27, 2020
c3dec9d
[CHORE] Update SDK
djorkaeffalexandre Mar 27, 2020
8f8f1dc
[REVERT] Undo some changes on SDK
djorkaeffalexandre Mar 27, 2020
a8e0f1c
LoginServices component
diegolmello Mar 27, 2020
3f0fcd5
Refactor
diegolmello Mar 27, 2020
a2dbfae
[CHORE] Update sdk to prevent incorrect subscribes
djorkaeffalexandre Mar 27, 2020
9046784
Multiple servers
diegolmello Mar 27, 2020
da64a51
Remove native images
diegolmello Mar 27, 2020
6111ca3
Refactor styles
diegolmello Mar 27, 2020
77000bb
Fix testid
diegolmello Mar 27, 2020
1bc9806
Fix add server on tablet
diegolmello Mar 27, 2020
0dc6717
i18n
diegolmello Mar 27, 2020
e87b159
Merge branch 'develop' into new.onboarding
diegolmello Mar 27, 2020
be7e859
Merge remote-tracking branch 'origin/new.onboarding' into beta
diegolmello Mar 27, 2020
9ef3aaf
Merge remote-tracking branch 'origin/test.sdk-disconnect' into beta
diegolmello Mar 27, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions __mocks__/@rocket.chat/sdk.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export class Rocketchat {}
export const settings = {};
190 changes: 95 additions & 95 deletions __tests__/__snapshots__/Storyshots.test.js.snap

Large diffs are not rendered by default.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed android/app/src/main/res/drawable-hdpi/options.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed android/app/src/main/res/drawable-mdpi/options.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed android/app/src/main/res/drawable-xhdpi/options.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed android/app/src/main/res/drawable-xxhdpi/options.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
3 changes: 3 additions & 0 deletions app/constants/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ export default {
Accounts_AllowUserProfileChange: {
type: 'valueAsBoolean'
},
Accounts_AllowUserStatusMessageChange: {
type: 'valueAsBoolean'
},
Accounts_AllowUsernameChange: {
type: 'valueAsBoolean'
},
Expand Down
2 changes: 1 addition & 1 deletion app/constants/tablet.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export const MAX_SIDEBAR_WIDTH = 321;
export const MAX_CONTENT_WIDTH = '90%';
export const MAX_SCREEN_CONTENT_WIDTH = '45%';
export const MAX_SCREEN_CONTENT_WIDTH = '50%';
export const MIN_WIDTH_SPLIT_LAYOUT = 700;
33 changes: 33 additions & 0 deletions app/containers/AppVersion.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import React from 'react';
import { StyleSheet, View, Text } from 'react-native';
import PropTypes from 'prop-types';

import { themes } from '../constants/colors';
import sharedStyles from '../views/Styles';
import { getReadableVersion } from '../utils/deviceInfo';

const styles = StyleSheet.create({
container: {
alignItems: 'center',
justifyContent: 'flex-end'
},
text: {
...sharedStyles.textRegular,
fontSize: 13
},
bold: {
...sharedStyles.textSemibold
}
});

const Check = React.memo(({ theme }) => (
<View style={styles.container}>
<Text style={[styles.text, { color: themes[theme].auxiliaryText }]}>App Version: <Text style={styles.bold}>{getReadableVersion}</Text></Text>
</View>
));

Check.propTypes = {
theme: PropTypes.string
};

export default Check;
27 changes: 18 additions & 9 deletions app/containers/Button/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@ import ActivityIndicator from '../ActivityIndicator';

const styles = StyleSheet.create({
container: {
paddingHorizontal: 15,
paddingHorizontal: 14,
justifyContent: 'center',
height: 48,
borderRadius: 2,
marginBottom: 10
marginBottom: 12
},
text: {
fontSize: 18,
textAlign: 'center'
fontSize: 16,
textAlign: 'center',
...sharedStyles.textMedium
}
});

Expand All @@ -30,6 +31,8 @@ export default class Button extends React.PureComponent {
backgroundColor: PropTypes.string,
loading: PropTypes.bool,
theme: PropTypes.string,
color: PropTypes.string,
fontSize: PropTypes.string,
style: PropTypes.any
}

Expand All @@ -43,9 +46,15 @@ export default class Button extends React.PureComponent {

render() {
const {
title, type, onPress, disabled, backgroundColor, loading, style, theme, ...otherProps
title, type, onPress, disabled, backgroundColor, color, loading, style, theme, fontSize, ...otherProps
} = this.props;
const isPrimary = type === 'primary';

let textColor = isPrimary ? themes[theme].buttonText : themes[theme].bodyText;
if (color) {
textColor = color;
}

return (
<Touchable
onPress={onPress}
Expand All @@ -55,20 +64,20 @@ export default class Button extends React.PureComponent {
backgroundColor
? { backgroundColor }
: { backgroundColor: isPrimary ? themes[theme].actionTintColor : themes[theme].backgroundColor },
disabled && { backgroundColor: themes[theme].borderColor },
disabled && { opacity: 0.3 },
style
]}
{...otherProps}
>
{
loading
? <ActivityIndicator color={isPrimary ? themes[theme].buttonText : themes[theme].actionTintColor} />
? <ActivityIndicator color={textColor} />
: (
<Text
style={[
styles.text,
isPrimary ? sharedStyles.textMedium : sharedStyles.textBold,
{ color: isPrimary ? themes[theme].buttonText : themes[theme].actionTintColor }
{ color: textColor },
fontSize && { fontSize }
]}
>
{title}
Expand Down
51 changes: 51 additions & 0 deletions app/containers/FormContainer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import React from 'react';
import { ScrollView, StyleSheet, View } from 'react-native';
import PropTypes from 'prop-types';
import { SafeAreaView } from 'react-navigation';

import { themes } from '../constants/colors';
import sharedStyles from '../views/Styles';
import scrollPersistTaps from '../utils/scrollPersistTaps';
import KeyboardView from '../presentation/KeyboardView';
import StatusBar from './StatusBar';
import AppVersion from './AppVersion';
import { isTablet } from '../utils/deviceInfo';

const styles = StyleSheet.create({
scrollView: {
minHeight: '100%'
}
});

export const FormContainerInner = ({ children }) => (
<View style={[sharedStyles.container, isTablet && sharedStyles.tabletScreenContent]}>
{children}
</View>
);

const FormContainer = ({ children, theme }) => (
<KeyboardView
style={{ backgroundColor: themes[theme].backgroundColor }}
contentContainerStyle={sharedStyles.container}
keyboardVerticalOffset={128}
>
<StatusBar theme={theme} />
<ScrollView {...scrollPersistTaps} style={sharedStyles.container} contentContainerStyle={[sharedStyles.containerScrollView, styles.scrollView]}>
<SafeAreaView style={sharedStyles.container} forceInset={{ top: 'never' }}>
{children}
<AppVersion theme={theme} />
</SafeAreaView>
</ScrollView>
</KeyboardView>
);

FormContainer.propTypes = {
theme: PropTypes.string,
children: PropTypes.element
};

FormContainerInner.propTypes = {
children: PropTypes.element
};

export default FormContainer;
20 changes: 12 additions & 8 deletions app/containers/HeaderButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,16 @@ export const DrawerButton = React.memo(({ navigation, testID, ...otherProps }) =
</CustomHeaderButtons>
));

export const CloseModalButton = React.memo(({ navigation, testID }) => (
<CustomHeaderButtons left>
<Item title='close' iconName='cross' onPress={() => navigation.pop()} testID={testID} />
</CustomHeaderButtons>
));
export const CloseModalButton = React.memo(({ navigation, testID, onPress }) => {
onPress = onPress || navigation.pop;
return (
<CustomHeaderButtons left>
<Item title='close' iconName='cross' onPress={onPress} testID={testID} />
</CustomHeaderButtons>
);
});

export const CloseShareExtensionButton = React.memo(({ onPress, testID }) => (
export const CancelModalButton = React.memo(({ onPress, testID }) => (
<CustomHeaderButtons left>
{isIOS
? <Item title={I18n.t('Cancel')} onPress={onPress} testID={testID} />
Expand Down Expand Up @@ -76,9 +79,10 @@ DrawerButton.propTypes = {
};
CloseModalButton.propTypes = {
navigation: PropTypes.object.isRequired,
testID: PropTypes.string.isRequired
testID: PropTypes.string.isRequired,
onPress: PropTypes.func
};
CloseShareExtensionButton.propTypes = {
CancelModalButton.propTypes = {
onPress: PropTypes.func.isRequired,
testID: PropTypes.string.isRequired
};
Expand Down
4 changes: 3 additions & 1 deletion app/containers/ListItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ const styles = StyleSheet.create({
});

const Content = React.memo(({
title, subtitle, disabled, testID, right, color, theme
title, subtitle, disabled, testID, left, right, color, theme
}) => (
<View style={[styles.container, disabled && styles.disabled]} testID={testID}>
{left ? left() : null}
<View style={styles.textContainer}>
<Text style={[styles.title, { color: color || themes[theme].titleText }]}>{title}</Text>
{subtitle
Expand Down Expand Up @@ -79,6 +80,7 @@ Item.propTypes = {
Content.propTypes = {
title: PropTypes.string.isRequired,
subtitle: PropTypes.string,
left: PropTypes.func,
right: PropTypes.func,
disabled: PropTypes.bool,
testID: PropTypes.string,
Expand Down
Loading