Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Bottom View color when using iPad #4643

Merged
merged 5 commits into from
Dec 5, 2022
Merged

[FIX] Bottom View color when using iPad #4643

merged 5 commits into from
Dec 5, 2022

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Nov 1, 2022 •
edited by jira bot
Loading

Proposed changes

This PR is just to test the PR properly from ui-lib RocketChat/react-native-ui-lib#7

After approving and merging that PR, we can close this.

Issue(s)

How to test or reproduce

  • Using an iPad
  • Open a channel
  • then go to settings and change the theme from light to dark, or vice-versa

Screenshots

Before

Screen.Recording.2022-10-31.at.23.09.56.mov

After

Screen.Recording.2022-10-31.at.19.09.23.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

TC-208

@reinaldonetof reinaldonetof self-assigned this Nov 1, 2022
@diegolmello diegolmello changed the title [FIX] Bottom View color when using iPAD [FIX] Bottom View color when using iPad Nov 3, 2022
@diegolmello diegolmello force-pushed the fix.messagebox-on-ipad branch from 31f24eb to c99aa0c Compare November 21, 2022 15:53
@reinaldonetof reinaldonetof merged commit 0066117 into develop Dec 5, 2022
@reinaldonetof reinaldonetof deleted the fix.messagebox-on-ipad branch December 5, 2022 15:19
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof
[FIX] Bottom View color when using iPad (RocketChat#4643)
b6a3d35 
* [FIX] Bottom View color when using iPAD

* [FIX] Bottom View color when using iPAD

* tweak on path to react-native-ui-lib in package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees

@reinaldonetof reinaldonetof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinaldonetof @diegolmello