Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unwanted clear keychain and request challenges #4826

Merged
merged 5 commits into from
Jan 18, 2023

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Jan 17, 2023

Proposed changes

  • Fixes the completion of some request challenges. They were return null, and by doing so, the request would not complete. That's the symptom seen on Log in bug: Having to uninstall app on IOS #4431
  • Removes an unnecessary clear keychain on MMKV patch

Issue(s)

How to test or reproduce

  • As described on Log in bug: Having to uninstall app on IOS #4431, but the infinite loading can be reproduced by running the flow below on Maestro
    • You'll notice the request challenges are fixed (no more infinite loading), but MMKV isn't persisted anymore
    • I didn't want to add a workaround for the clear keychain, since the keychain being cleared is the real issue
  • SSL Client Certificate
  • Secured Push Notification
  • Login with SSO
appId: chat.rocket.reactnative
---
- launchApp:
    clearKeychain: true
- tapOn: 'Join our open workspace'

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log in bug: Having to uninstall app on IOS
2 participants