Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add valid version with valid exception use case #5368

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix: Add valid version with valid exception use case #5368

merged 2 commits into from
Nov 27, 2023

Conversation

diegolmello
Copy link
Member

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello changed the title Fix: Add valid version with valid exception use case fix: Add valid version with valid exception use case Nov 27, 2023
@diegolmello diegolmello merged commit 16347b0 into develop Nov 27, 2023
@diegolmello diegolmello deleted the fix.sv-exceptions branch November 27, 2023 18:28
reinaldonetof added a commit that referenced this pull request Dec 11, 2023
@reinaldonetof
Merge branch 'develop' into TC-782-Mobile-Troubleshoot-notifications
6c7514c 
* develop: (24 commits)
  fix: add type checking on notificationType (#5376)
  fix: call the internetStateMiddleware for release mode (#5364)
  improve: handle attachment actions in a quote and how to jump to message (#5363)
  fix: translation prop checking (#5369)
  fix: handle camera permission crash (#5372)
  feat (iOS): mobile ringer (#5327)
  fix: enables navigation for deleted threads (#5317)
  fix: Add valid version with valid exception use case (#5368)
  feat (Android): mobile ringer (#5286)
  chore: Remove pre-commit hook (#5362)
  chore: Remove unused Jitsi deep link (#5361)
  fix(Android): Deep links not working on Android 12 (#5357)
  chore: Bump version to 4.44.0 (#5358)
  fix(iOS): Keyboard not working properly on iOS 17 (#5343)
  fix: call media permissions in android 13+ (#5326)
  feat: new audio player (#5160)
  feat: capability to enable/disable writing in rooms read only (#5298)
  fix: starting a new thread from an attachment (#5345)
  fix: show last message when pinned (#5316)
  chore: Bump version to 4.43.0 (#5341)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanfbrito jeanfbrito jeanfbrito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegolmello @jeanfbrito