fix: Make file format attachment less rigid #5883
Merged
+1
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In some cases, the URL returned by
formatAttachmentUrl
wouldn't consider local files and the code would get to this lineRocket.Chat.ReactNative/app/lib/methods/helpers/formatAttachmentUrl.ts
Line 32 in 7913429
The result would be an invalid URL like
${server}${localFile}
->https://open.rocket.chatfile://var/mobile...
I was not able to reproduce the issue, but since the code on this function is fairly straightforward and the only condition that should consider local files was based on a specific local directory (
FileSystem.documentDirectory
), I've decided to relax this rule a little bit by just checkingfile://
.Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
NATIVE-655