Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added letter-spacing to fix Inter Regular line break issue #5892

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

OtavioStasiak
Copy link
Contributor

Proposed changes

Android was not Mobile app not showing entire message in the Inter-Regular font.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-657

How to test or reproduce

  • Open the app;
  • Select a room;
  • Send the message : 'Perfect, I will let them know. Thank you. Also happy to look at the FlieVlaut stuff with you.'
  • Send the message: 'テスト'

Screenshots

Before/After video:

untitled.webm

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

@diegolmello diegolmello force-pushed the fix-font-inter-android-error branch from b4301af to e309066 Compare October 2, 2024 18:53
@diegolmello diegolmello merged commit 2df8a0b into develop Oct 2, 2024
13 of 18 checks passed
@diegolmello diegolmello deleted the fix-font-inter-android-error branch October 2, 2024 21:02
OtavioStasiak added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants