Skip to content

chore: bump ubuntu #35676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025
Merged

chore: bump ubuntu #35676

merged 5 commits into from
Apr 1, 2025

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 1, 2025

https://rocketchat.atlassian.net/browse/ARCH-1532

This is a scheduled Ubuntu 20.04 brownout.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Apr 1, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: 558407d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 1, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35676/

Built to branch gh-pages at 2025-04-01 19:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (2cce386) to head (b0ca366).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35676      +/-   ##
===========================================
- Coverage    59.66%   59.63%   -0.03%     
===========================================
  Files         2829     2829              
  Lines        68287    68284       -3     
  Branches     15141    15132       -9     
===========================================
- Hits         40742    40720      -22     
- Misses       24934    24954      +20     
+ Partials      2611     2610       -1     
Flag Coverage Δ
unit 75.64% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.5.0 milestone Apr 1, 2025
@ggazzo ggazzo force-pushed the chore/ubuntu-latest branch from 674442f to ac5849b Compare April 1, 2025 18:29
@ggazzo ggazzo marked this pull request as ready for review April 1, 2025 18:30
@ggazzo ggazzo requested a review from a team as a code owner April 1, 2025 18:30
sampaiodiego
sampaiodiego previously approved these changes Apr 1, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 1, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 1, 2025
debdutdeb
debdutdeb previously approved these changes Apr 1, 2025
d-gubert
d-gubert previously approved these changes Apr 1, 2025
gabriellsh
gabriellsh previously approved these changes Apr 1, 2025
@ggazzo ggazzo dismissed stale reviews from gabriellsh, d-gubert, debdutdeb, and sampaiodiego via 4225e5b April 1, 2025 19:15
@ggazzo ggazzo force-pushed the chore/ubuntu-latest branch from a4ae89f to 558407d Compare April 1, 2025 19:20
@kodiakhq kodiakhq bot merged commit 183c43c into develop Apr 1, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the chore/ubuntu-latest branch April 1, 2025 20:59
ggazzo added a commit that referenced this pull request Apr 1, 2025
ahmed-n-abdeltwab added a commit to ahmed-n-abdeltwab/Rocket.Chat that referenced this pull request Apr 2, 2025
@sampaiodiego
Copy link
Member

/backport 7.4.2

Copy link
Contributor

dionisio-bot bot commented Apr 8, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.4.2-35676
git cherry-pick 183c43c92def58b21e55bcbda81bedd768c772a9
// solve the conflict
git push

after that just run /backport 7.4.2 again

sampaiodiego pushed a commit that referenced this pull request Apr 8, 2025
@sampaiodiego
Copy link
Member

/backport 7.4.2

@dionisio-bot dionisio-bot bot mentioned this pull request Apr 8, 2025
Copy link
Contributor

dionisio-bot bot commented Apr 8, 2025

Pull request #35739 added to Project: "Patch 7.4.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants