feat: Draggable Voice/Video call popup #35830
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: aa7cdbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kodus-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
packages/ui-voip/src/components/VoipPopupDraggable/DraggableCore.ts
Outdated
Show resolved
Hide resolved
packages/ui-voip/src/components/VoipPopupDraggable/DraggableCore.ts
Outdated
Show resolved
Hide resolved
packages/ui-voip/src/components/VoipPopupDraggable/VoipPopupDraggable.tsx
Show resolved
Hide resolved
packages/ui-voip/src/components/VoipPopupDraggable/VoipPopupDraggable.tsx
Show resolved
Hide resolved
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35830 +/- ##
===========================================
- Coverage 61.17% 61.04% -0.13%
===========================================
Files 2971 2978 +7
Lines 70839 71060 +221
Branches 16185 16213 +28
===========================================
+ Hits 43333 43379 +46
- Misses 24556 24714 +158
- Partials 2950 2967 +17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
There was a problem hiding this comment.
Copilot reviewed 25 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (2)
- packages/i18n/src/locales/en.i18n.json: Language not supported
- packages/ui-voip/src/components/VoipPopup/snapshots/VoipPopup.spec.tsx.snap: Language not supported
Comments suppressed due to low confidence (2)
packages/ui-voip/src/components/VoipPopup/VoipPopup.tsx:13
- Ensure that the forwarded ref behavior in VoipPopup (and its conditional children) is covered with tests to verify that the ref is correctly attached to the underlying container element.
const VoipPopup = forwardRef<HTMLDivElement, { position?: PositionOffsets }>(({ position, ...props }, ref) => {
packages/ui-client/src/hooks/useFeaturePreviewList.ts:9
- Consider adding or updating tests to validate the behavior of the new 'voip-draggable' feature flag to ensure that the feature preview is correctly enabled or disabled under various scenarios.
| 'voip-draggable';
| const DRAG_START_EVENTS = ['mousedown', 'touchstart'] as const; | ||
| const DRAG_END_EVENTS = ['mouseup', 'touchend'] as const; | ||
| const DRAG_MOVE_EVENTS = ['mousemove', 'touchmove'] as const; |
There was a problem hiding this comment.
Have you considered using pointer events instead?
They’re well supported in modern browsers and can help unify mouse and touch event handling.
Depending on how old the browsers we need to support are, this might be a good improvement.
Proposed changes (including videos or screenshots)
This will be released as a feature preview.
Allows the call widget to be dragged on the screen.
This is pretty much a beta. All the logic related to positioning, transforms and events abastraction will be moved to fuselage and released as a separate package.
Screen.Recording.2025-04-16.at.18.07.34.mov
Issue(s)
CORE-954
Steps to test or reproduce
Further comments