Skip to content

chore: apply useQuery on InviteUsers #35861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

chore: apply useQuery on InviteUsers #35861

wants to merge 6 commits into from
+882 −85

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Apr 23, 2025 •
edited by kodus-ai bot
Loading

ARCH-1579

Proposed changes (including videos or screenshots)

In dev mode, invite links were being generated 2 times due to useEffect

  • replace endpoint call in useEffect in favor of useQuery
  • handle error state
  • handle loading state
  • handle success state

Issue(s)

Steps to test or reproduce

Further comments

This pull request focuses on refactoring the InviteUsers functionality within the Rocket.Chat application. The main change involves applying useQuery for data fetching in the InviteUsers component. The update includes the removal of existing error handling and the Callout component, which may affect error visibility and user experience. To address error handling, a new component, InviteUsersError, is introduced to manage and display errors during the user invitation process. Additionally, a new loading component, InviteUsersLoading, is added to enhance the user interface during the invitation process. The InviteUsersWithData component is refactored to incorporate React Query for improved data management and state handling. While the code is generally well-structured, there are suggestions for further improvements in error handling and type safety across the new components.

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 569847d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodus-ai Kodus AI
Copy link

kodus-ai bot commented Apr 23, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35861/

Built to branch gh-pages at 2025-04-24 18:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 61.21%. Comparing base (b7e6730) to head (569847d).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35861      +/-   ##
===========================================
- Coverage    61.21%   61.21%   -0.01%     
===========================================
  Files         3007     3011       +4     
  Lines        71472    71486      +14     
  Branches     16343    16345       +2     
===========================================
+ Hits         43752    43758       +6     
- Misses       24752    24760       +8     
  Partials      2968     2968
Flag Coverage Δ
e2e 57.85% <15.62%> (-0.01%) ⬇️
unit 75.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kodus-ai Kodus AI
Copy link

kodus-ai bot commented Apr 23, 2025 •
edited
Loading

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kodus-ai Kodus AI

This comment was marked as duplicate.

Sign in to view
1 similar comment
@kodus-ai Kodus AI

This comment was marked as duplicate.

Sign in to view
@juliajforesti juliajforesti marked this pull request as ready for review April 24, 2025 14:42
@juliajforesti juliajforesti requested a review from a team as a code owner April 24, 2025 14:42
dougfabris
dougfabris reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have some snapshots and a11y tests in these screens

@kodus-ai Kodus AI
Copy link

kodus-ai bot commented Apr 24, 2025 •
edited
Loading

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kodus-ai Kodus AI

This comment was marked as duplicate.

Sign in to view
dougfabris
dougfabris reviewed Apr 24, 2025
View reviewed changes
apps/meteor/client/views/room/contextualBar/RoomMembers/InviteUsers/InviteUsersLoading.tsx

const InviteUsersLoading = ({ onClose, onClickBack: onClickBackMembers }: InviteUsersProps): ReactElement => (
<InviteUsersWrapper onClose={onClose} onClickBack={onClickBackMembers}>
<Skeleton w='full' />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we try to render something similar to the ContextualbarSkeleton?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ContextualbarSkeleton is loading the whole contextualbar - header title and content - and has no Back or Close buttons.
In this case we have all these info loaded already, so I decided to put a skeleton only on the content that is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris left review comments

@kodus-ai kodus-ai[bot] kodus-ai[bot] left review comments

@aleksandernsilva aleksandernsilva Awaiting requested review from aleksandernsilva

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliajforesti @aleksandernsilva @dougfabris