Update to webpack v5 #382
Merged
Update to webpack v5 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LisaManresa
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewing this one @LisaManresa if you could pull it down and run all of the various npm scripts through to make sure this doesn't break any of your day-to-day.
There's a few small known issues addressed here, but I'm comfortable moving forward.
webpack-dev-server's hot reload is currently failing when the target is set to browserlist which is automatically true for our config. But we can set it towebfor local development re: webpack/webpack-dev-server#2758 (comment). I don't love this as it means we're not compiling the exact same settings for dev as we are for prod however they're currently working on a fix and we probably don't really have a situation in which this would break something...webpack-dev-server's--opencli flag is broken, so that configuration needed to move towebpack.config.jsand called withwebpack servewebpack/webpack-dev-server#2765 (comment)html-webpack-pluginwasn't using the correct hooks for webpack v5 and is currently working on fixing that in their alpha release. The changes are small and the alpha addresses the issue for our use case, so I'm pretty confident in making that shift as otherwise it seems to work fine. jantimon/html-webpack-plugin#1527 (comment)