-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out errors from CompletableAction.completions
#236
Filter out errors from CompletableAction.completions
#236
Conversation
Seems reasonable, but it would be a breaking API change. I'll request some reviews from others to gather feedback 👍 |
LGTM as well. The change is behavioural as far as I can see, API itself is intact. AFAICT, it doesn't contradict with neither how it is named @sdanny We may need however to detail documentation a bit and add entry to CHANGELOG |
@mosamer thank you 🙌 I agree the shape of the API itself doesn't change, but the semantics do in a way that warrants a major version bump. The current version is 4.3.0, so the next version with this change should be 5.0.0. |
@ashfurrow IMHO this is more of a bug fix, comparing it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, it's been a week and we've gotten no more feedback, so let's merge 👍 I'll get this deployed ASAP and follow up.
Thanks a lot for contributing @sdanny! I've invited you to join the Generated by 🚫 dangerJS |
Cool! This is released as version 5.0.0. I ran into this error from CocoaPods during |
Problem statement
CompletableAction
is usually used in some repeatable manner. Each action can finish with an error especially if there's a network request or a validation process inside theworkFactory
. So farcompletions
emits these errors which in turn disposes existing subscriptions to this observable.Proposed solution
Catch errors in
completions
.#trivial