Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Fallback Solution for Electron and VSCode #95

Closed
wants to merge 1 commit into from
Closed

added Fallback Solution for Electron and VSCode #95

wants to merge 1 commit into from

Conversation

Mabenan
Copy link

@Mabenan Mabenan commented Jul 24, 2019

Solve for Issue #94

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Richter Daniel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bsrdjan
Copy link
Contributor

bsrdjan commented Jun 11, 2020

Thank you very much @Mabenan for the PR. After replacing GYP with CMAKE the fix not needed any more.

@bsrdjan bsrdjan closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants