Skip to content

fix(styles): update Action Sheet [ci visual] #6028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Apr 14, 2025

Related Issue

Part of #5763

Description

  • design updates for Action Sheet
  • no a11y updates needed

BREAKING CHANGES:
Action Sheet Title is now in a Bar component.

Before:

<div class="fd-action-sheet__wrapper fd-action-sheet__wrapper--active" id="actionSheetPhone">
    <h6 class="fd-action-sheet__title">Press cancel to hide action sheet</h6>
    <ul class="fd-action-sheet fd-action-sheet--mobile">...</ul>
</div>

After:

<div class="fd-action-sheet__wrapper fd-action-sheet__wrapper--active" id="actionSheetPhone">
    <div class="fd-bar fd-action-sheet__bar" role="toolbar" aria-label="Bar">
        <div class="fd-bar__left">
            <div class="fd-bar__element">
                <h6 class="fd-action-sheet__title">Control Title</h6>
            </div>
         </div>
    </div>
    <ul class="fd-action-sheet fd-action-sheet--mobile">...</ul>
</div>

@InnaAtanasova InnaAtanasova added this to the Sprint 145 - April 2025 milestone Apr 14, 2025
@InnaAtanasova InnaAtanasova requested a review from a team April 14, 2025 20:05
@InnaAtanasova InnaAtanasova self-assigned this Apr 14, 2025
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit b9f693f
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/67fd6a988d8f370008b6d65e
😎 Deploy Preview https://deploy-preview-6028--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InnaAtanasova InnaAtanasova merged commit da094df into main Apr 16, 2025
10 checks passed
@InnaAtanasova InnaAtanasova deleted the fix/action-sheet-updates branch April 16, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants