Skip to content

fix(styles): add design and a11y updates for Button controls [ci visual] #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix(styles): add design and a11y updates for Button controls [ci visual] #6029

merged 1 commit into from
Apr 17, 2025

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Apr 15, 2025 •
edited
Loading

Related Issue

Part of #5763

Description

  • design changes: for Menu Button with fixed width
  • a11y: roles, aria attributes, etc. Breaking changes for Segmented button

BREAKING CHANGE:
Segmented button has different role and attributes

@InnaAtanasova InnaAtanasova added A11y Accessibility concerns or improvements design changes labels Apr 15, 2025
@InnaAtanasova InnaAtanasova added this to the Sprint 145 - April 2025 milestone Apr 15, 2025
@InnaAtanasova InnaAtanasova requested a review from a team April 15, 2025 20:15
@InnaAtanasova InnaAtanasova self-assigned this Apr 15, 2025
@InnaAtanasova InnaAtanasova mentioned this pull request Apr 15, 2025
Open
24 tasks
@netlify Netlify
Copy link

netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 354d7c3
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/67ffe878680fcf0008ffe232
😎 Deploy Preview https://deploy-preview-6029--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InnaAtanasova InnaAtanasova merged commit 7c9ad29 into main Apr 17, 2025
10 checks passed
@InnaAtanasova InnaAtanasova deleted the fix/button-controls branch April 17, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

Assignees

@InnaAtanasova InnaAtanasova

Labels
A11y Accessibility concerns or improvements design changes
Projects
None yet
Milestone
Sprint 145 - April 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@InnaAtanasova @droshev