Skip to content

BUG - fe-fpm-writer. Incorrect 'controlAggregation' applied when a new Object Page is added and FCL is enabled #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
815are opened this issue Apr 22, 2025 · 1 comment
Assignees
Labels
fe-fpm-writer @sap-ux/fe-fpm-writer

Comments

@815are
Copy link
Contributor

815are commented Apr 22, 2025

Steps to Reproduce

Steps to reproduce the behavior:

  1. Use manifest.json with routing like:
"routing": {
            "config": {
                "flexibleColumnLayout": {
                    "defaultTwoColumnLayoutType": "TwoColumnsBeginExpanded",
                    "defaultThreeColumnLayoutType": "ThreeColumnsMidExpanded"
                },
                "routerClass": "sap.f.routing.Router"
            },
            "routes": [
                {
                    "pattern": ":?query:",
                    "name": "TripsList",
                    "target": [
                        "TripsList"
                    ]
                },
                {
                    "name": "TripsObjectPage",
                    "pattern": "Trips({TripsKey}):?query:",
                    "target": [
                        "TripsList",
                        "TripsObjectPage"
                    ]
                }
            ],
            "targets": {
                "TripsList": {
                    "type": "Component",
                    "id": "TripsList",
                    "name": "sap.fe.templates.ListReport",
                    "options": {
                        "settings": {
                            "contextPath": "/Trips",
                            "variantManagement": "Page",
                            "initialLoad": "Enabled",
                            "navigation": {
                                "Trips": {
                                    "detail": {
                                        "route": "TripsObjectPage"
                                    }
                                }
                            }
                        }
                    },
                    "controlAggregation": "beginColumnPages",
                    "contextPattern": ""
                },
                "TripsObjectPage": {
                    "type": "Component",
                    "id": "TripsObjectPage",
                    "name": "sap.fe.templates.ObjectPage",
                    "controlAggregation": "midColumnPages",
                    "options": {
                        "settings": {
                            "navigation": {},
                            "contextPath": "/Trips"
                        }
                    },
                    "contextPattern": "/Trips({TripsKey})"
                }
            }
        },
  1. Add new object page to TripsObjectPage while FCL is enabled.
  2. Problem - controlAggregation of new Object Page is beginColumnPages instead of endColumnPages

Expected results

controlAggregation of new Object Page is endColumnPages

Actual results

controlAggregation of new Object Page is beginColumnPages instead of endColumnPages

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@815are
Copy link
Contributor Author

815are commented Apr 22, 2025

Fix - #3168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-fpm-writer @sap-ux/fe-fpm-writer
Projects
None yet
Development

No branches or pull requests

1 participant