-
Notifications
You must be signed in to change notification settings - Fork 42
fix: correct control aggregation for object page when fcl is enabled #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct control aggregation for object page when fcl is enabled #3168
Conversation
correct control aggregation for object page when fcl is enabled
🦋 Changeset detectedLatest commit: 6331383 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
additional tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config for controlAggregation fixed, change tested, changeset added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are clear and covered by test.
changeset ✅
|
Issue #3170
Scenario:
manifest.json
with routing like:TripsObjectPage
while FCL is enabled.Problem -
controlAggregation
of new Object Page isbeginColumnPages
instead ofendColumnPages
Issue
navigation
was not passed to methodgetFclConfig