[FIX] NumberFormat: make NumberFormat.RoundingMode guideline compliant

- The key and value should have the same string value in an UI5 enum.
  Thus the NumberFormat.RoundingMode needs to be adapted and we now
  support both all lower and all upper case letters.

BCP: 1870335948
Fixes: #2169
Change-Id: Icf7e486d247698023230d7002496a9711c74b120

Author: stopcoder

src/sap.ui.core/src/sap/ui/core/format/NumberFormat.js

@@ -72,49 +72,49 @@ sap.ui.define([
 		 * @public
 		 * @type {string}
 		 */
-		FLOOR: "floor",
+		FLOOR: "FLOOR",
 		/**
 		 * Rounding mode to round towards positive infinity
 		 * @public
 		 * @type {string}
 		 */
-		CEILING: "ceiling",
+		CEILING: "CEILING",
 		/**
 		 * Rounding mode to round towards zero
 		 * @public
 		 * @type {string}
 		 */
-		TOWARDS_ZERO: "towards_zero",
+		TOWARDS_ZERO: "TOWARDS_ZERO",
 		/**
 		 * Rounding mode to round away from zero
 		 * @public
 		 * @type {string}
 		 */
-		AWAY_FROM_ZERO: "away_from_zero",
+		AWAY_FROM_ZERO: "AWAY_FROM_ZERO",
 		/**
 		 * Rounding mode to round towards the nearest neighbor unless both neighbors are equidistant, in which case round towards negative infinity.
 		 * @public
 		 * @type {string}
 		 */
-		HALF_FLOOR: "half_floor",
+		HALF_FLOOR: "HALF_FLOOR",
 		/**
 		 * Rounding mode to round towards the nearest neighbor unless both neighbors are equidistant, in which case round towards positive infinity.
 		 * @public
 		 * @type {string}
 		 */
-		HALF_CEILING: "half_ceiling",
+		HALF_CEILING: "HALF_CEILING",
 		/**
 		 * Rounding mode to round towards the nearest neighbor unless both neighbors are equidistant, in which case round towards zero.
 		 * @public
 		 * @type {string}
 		 */
-		HALF_TOWARDS_ZERO: "half_towards_zero",
+		HALF_TOWARDS_ZERO: "HALF_TOWARDS_ZERO",
 		/**
 		 * Rounding mode to round towards the nearest neighbor unless both neighbors are equidistant, in which case round away from zero.
 		 * @public
 		 * @type {string}
 		 */
-		HALF_AWAY_FROM_ZERO: "half_away_from_zero"
+		HALF_AWAY_FROM_ZERO: "HALF_AWAY_FROM_ZERO"
 	};
 
 	var mRoundingFunction = {};
@@ -2082,6 +2082,14 @@ sap.ui.define([
 			// Support custom function for rounding the number
 			fValue = sRoundingMode(fValue, iMaxFractionDigits);
 		} else {
+			// The NumberFormat.RoundingMode had all values in lower case before and later changed all values to upper case
+			// to match the key according to the UI5 guideline for defining enum. Therefore it's needed to support both
+			// lower and upper cases. Here checks whether the value has only lower case letters and converts it all to upper
+			// case if so.
+			if (sRoundingMode.match(/^[a-z_]+$/)) {
+				sRoundingMode = sRoundingMode.toUpperCase();
+			}
+
 			if (!iMaxFractionDigits) {
 				return mRoundingFunction[sRoundingMode](fValue);
 			}

src/sap.ui.core/test/sap/ui/core/qunit/types/NumberFormat.qunit.js

@@ -962,6 +962,22 @@ sap.ui.define(["sap/ui/core/format/NumberFormat", "sap/ui/core/Locale", "sap/ui/
 		assert.equal(oFormat.format(-.1236), "-0.123", "-.1236");
 	});
 
+	QUnit.test("float format with rounding mode: CEILING (via legacy all lower case letters: ceiling)", function (assert) {
+		var oFormat = NumberFormat.getFloatInstance({
+			maxFractionDigits: 3,
+			roundingMode: "ceiling"
+		});
+
+		assert.equal(oFormat.format(.1230), "0.123", ".123");
+		assert.equal(oFormat.format(.1234), "0.124", ".1234");
+		assert.equal(oFormat.format(.1235), "0.124", ".1235");
+		assert.equal(oFormat.format(.1239), "0.124", ".1239");
+		assert.equal(oFormat.format(2.1999), "2.2", "2.1999");
+		assert.equal(oFormat.format(2.11), "2.11", "2.11");
+		assert.equal(oFormat.format(-.1234), "-0.123", "-.1234");
+		assert.equal(oFormat.format(-.1236), "-0.123", "-.1236");
+	});
+
 	QUnit.test("float format with rounding mode: CEILING with decimals set to a string which contains a number", function (assert) {
 		var oFormat = NumberFormat.getFloatInstance({
 			decimals: "3",