Enum: RoundingMode Key-Value Pairs Not Identical

[boghyon]

Currently, the RoundingMode key-value pairs are not identical to each other.

openui5/src/sap.ui.core/src/sap/ui/core/format/NumberFormat.js

Lines 108 to 152 in 7bfdad7

	* @enum {string}
	* @alias sap.ui.core.format.NumberFormat.RoundingMode
	*/
	var mRoundingMode = {
	/**
	* Rounding mode to round towards negative infinity
	* @public
	*/
	FLOOR: "floor",
	/**
	* Rounding mode to round towards positive infinity
	* @public
	*/
	CEILING: "ceiling",
	/**
	* Rounding mode to round towards zero
	* @public
	*/
	TOWARDS_ZERO: "towards_zero",
	/**
	* Rounding mode to round away from zero
	* @public
	*/
	AWAY_FROM_ZERO: "away_from_zero",
	/**
	* Rounding mode to round towards the nearest neighbor unless both neighbors are equidistant, in which case round towards negative infinity.
	* @public
	*/
	HALF_FLOOR: "half_floor",
	/**
	* Rounding mode to round towards the nearest neighbor unless both neighbors are equidistant, in which case round towards positive infinity.
	* @public
	*/
	HALF_CEILING: "half_ceiling",
	/**
	* Rounding mode to round towards the nearest neighbor unless both neighbors are equidistant, in which case round towards zero.
	* @public
	*/
	HALF_TOWARDS_ZERO: "half_towards_zero",
	/**
	* Rounding mode to round towards the nearest neighbor unless both neighbors are equidistant, in which case round away from zero.
	* @public
	*/
	HALF_AWAY_FROM_ZERO: "half_away_from_zero"
	};

Why is this a problem?

Besides the doc saying to do so; when assigning enum values declaratively e.g. in XML or manifest.json, the actual values must be passed ("floor") instead of key names ("FLOOR").

1. Usually in JS, we can get the real values via sap.ui.define / .require. We can't require and assign enums declaratively in XML or JSON.
2. There is currently no way to discover the actual enum values without inspecting the source code since only keys are visible in API reference.

To make things worse; since the plain object that holds the roundingMode property is typically not derived from ManagedObject (e.g. the formatOptions object), there is no type validation either, unlike in #2166.

[GerganaKremenska]

Hello @boghyon ,
Thank you for sharing this finding. I've created an internal incident 1870335948. The status of the issue will be updated here in GitHub.
Regards,
Gergana

[stopcoder]

Hi @boghyon,

we finally made a fix and it's merged to the master branch a moment ago. We decided not to downport the fix. If you need this fix in the released branch as well, please reopen the ticket with the version info. We will then consider downporting the change.

Best regards,
Jiawei