-
Notifications
You must be signed in to change notification settings - Fork 1.2k
PDF Viewer on mozilla #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't get your point yet, @costinarsene. The code that you linked, uses arrow functions. Arrow functions use the same Maybe you can share the actual error that you encounter. That might help us in understanding what's going wrong. P.S.: I hope that the code in question wasn't downported to 1.96 as we don't support arrow functions in that code line |
The matter is about the precise version 1.96.38 in which there are clasic functions but that specific one is missing the .bind(this). This cause the script to run in an exception which is caught but the function (clasical function) in catch is also missing the .bind(this) |
@codeworrior I made a mistake. The issue is replicated on 1.96 until 1.108. Over there you did not use arrow function. I modified the initial issue. |
What is the issue and how can we reproduce it?
Inside PDFViewer.prototype._onLoadListener
on .then((sCurrentContentType) => {..}
missing .bind(this) . The same apllies for the next catch in current promise
It is replicated for 1.96 -1.108
Which OpenUI5 version is your project targeting?
1.96 -1.108
Is the issue device- or browser-specific?
Replicated on Firefox latest version
Confirmation
The text was updated successfully, but these errors were encountered: