Skip to content

chore: (CXSPA-9809) Continuum E2Es - Guest Checkout #20212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

chore: (CXSPA-9809) Continuum E2Es - Guest Checkout #20212

wants to merge 3 commits into from

Conversation

StanislavSukhanov
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov self-assigned this Apr 23, 2025
@github-actions github-actions bot marked this pull request as draft April 23, 2025 12:22
@StanislavSukhanov StanislavSukhanov marked this pull request as ready for review April 23, 2025 12:23
@cypress Cypress
Copy link

cypress bot commented Apr 23, 2025

spartacus    Run #47824

Run Properties:  status check passed Passed #47824  •  git commit 09b47509ea ℹ️: Merge e5ca70aa7d765ae4566b1877dc0657fcc683cd80 into 981af3aeb01bff72b50c6d997c15...
Project spartacus
Branch Review feature/CXSPA-9809-Continuum-E2Es---Guest-Checkout
Run status status check passed Passed #47824
Run duration 04m 46s
Commit git commit 09b47509ea ℹ️: Merge e5ca70aa7d765ae4566b1877dc0657fcc683cd80 into 981af3aeb01bff72b50c6d997c15...
Committer Stanislav Sukhanov
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 144
View all changes introduced in this branch ↗︎

Pio-Bar
Pio-Bar requested changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Pio-Bar Pio-Bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

A bunch of tests fail for me, can you double check?

Some problems may be related to the ngSelect issue I've also encountered and fixed here: CXSPA-9811

@StanislavSukhanov
Copy link
Contributor Author

Thank you @Pio-Bar. Weird, looking at it.

@github-actions github-actions bot marked this pull request as draft April 28, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pio-Bar Pio-Bar Pio-Bar requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@StanislavSukhanov StanislavSukhanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanislavSukhanov @Pio-Bar @Zeyber