Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image scale support in WebImage init #323

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Jun 25, 2024

Note:

  • ABI breaking change
  • non source breaking change

Do we need binary compatibility? If so we'll need more code to deal with it.

Close #322

@dreampiggy
Copy link
Collaborator

Do we need binary compatibility

No, no gurantee about this in version release...

@dreampiggy dreampiggy added API API changes webimage WebImage struct labels Jun 26, 2024
@dreampiggy dreampiggy merged commit 03c468b into SDWebImage:master Jun 26, 2024
6 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/kyle/scale branch June 26, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API changes webimage WebImage struct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can we specify URL image scale in WebImage
2 participants