Sourcery refactored master branch #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| board = [[None for x in range(BOARD_SIZE)] for y in range(BOARD_SIZE)] | ||
| board = [[None for _ in range(BOARD_SIZE)] for _ in range(BOARD_SIZE)] |
There was a problem hiding this comment.
Function Game.board refactored with the following changes:
- Replace unused for index with underscore [×2] (
for-index-underscore)
Comment on lines
-55
to
+60
| if form.is_valid(): | ||
| move.save() | ||
| return redirect("gameplay_detail", id) | ||
| else: | ||
| if not form.is_valid(): | ||
| return render( | ||
| request, "gameplay/game_detail.html", {"game": game, "form": form} | ||
| ) | ||
| move.save() | ||
| return redirect("gameplay_detail", id) |
There was a problem hiding this comment.
Function make_move refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-50
to
+59
| if request.method == "POST": | ||
| if "accept" in request.POST: | ||
| game = Game.manager.create( | ||
| firstPlayer=invitation.toUser, secondPlayer=invitation.fromUser, | ||
| ) | ||
| invitation.delete() | ||
| return redirect(game) | ||
| else: | ||
| if request.method != "POST": | ||
| return render( | ||
| request, "player/accept_invitation_form.html", {"invitation": invitation} | ||
| ) | ||
| if "accept" in request.POST: | ||
| game = Game.manager.create( | ||
| firstPlayer=invitation.toUser, secondPlayer=invitation.fromUser, | ||
| ) | ||
| invitation.delete() | ||
| return redirect(game) |
There was a problem hiding this comment.
Function accept_invitation refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
| x = 5 | ||
| y = 6 | ||
| assert x + 1 == y, "test failed" | ||
| pass |
There was a problem hiding this comment.
Function test_file1_method1 refactored with the following changes:
- Inline variable that is only used once [×2] (
inline-variable) - Remove
assert Truestatements (remove-assert-true) - Simplify numeric comparison (
simplify-numeric-comparison) - Simplify x == x -> True and x != x -> False (
equality-identity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!