fix: fix guesses for Real*Input and Real*Output
#291
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 61.53% 0.00% -61.54%
==========================================
Files 46 33 -13
Lines 1448 1630 +182
==========================================
- Hits 891 0 -891
- Misses 557 1630 +1073 ☔ View full report in Codecov by Sentry. |
src/Blocks/utils.jl
Outdated
| end | ||
| ODESystem(Equation[], t, [u...], []; name = name, guesses = [u => u_start]) | ||
| ODESystem(Equation[], t, [u], []; name = name, guesses = [u => u_start]) |
There was a problem hiding this comment.
If I as a user pass u_start=1 I want that to be true, not only a guess. I wonder if these u_start are needed at all?
There was a problem hiding this comment.
You should be able to change the guess. Why would this be a direct value instead of a guess? The value is set by the variable that defines the input and the function that defines the output, any default here would just be an extra equation causing an overconstrained system. Indeed if someone sets a default then it should be true, but why would it be normal to set an overconstrained system with inputs and outputs? We can make that another kwarg that is nothing by default?
There was a problem hiding this comment.
The keyword is u_start, don't you think users expect this variable start at the value provided?
There was a problem hiding this comment.
it should probably just be renamed guess and deprecate the old name.
There was a problem hiding this comment.
that would be much less confusing
There was a problem hiding this comment.
I'd prefer if we stop using the word "default" as well in favor of either "start" or "initial", but that's a discussion for another time and place :P
There was a problem hiding this comment.
Fixed in 7b38a53
|
Is this failure known? |
|
It's fixed in SciML/ModelingToolkit.jl#2677 |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.