Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

151 sort notes in dd mmm yyyy format #152

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

SebastianMC
Copy link
Owner

No description provided.

- additional unit tests
- fixes detected by unit tests

Next step: manual local testing of real scenarios
@SebastianMC SebastianMC linked an issue Jul 9, 2024 that may be closed by this pull request
@SebastianMC
Copy link
Owner Author

SebastianMC commented Jul 9, 2024

Testing - minor issue, the expected order is different (opposite) - why?

2024-07-09_11-32-01
  • must be fixed

@SebastianMC
Copy link
Owner Author

SebastianMC commented Jul 9, 2024

Testing - weird behavior of syntax check / popup.
Steps:
1 - Introduced syntax error
2 - clicked ribbon to enable sort, syntax error popup + red ribbon icon appeared
3 - fixed the syntax error, clicked ribbon, the 2nd instance of syntax error popup appeared, ribbon btn remained red
4 - click ribbon again, this time correct behavior, sorting applied

At the same time, if I wait between steps 2 and 3, the duplicate error popup doesn't appear and the sorting is applied correctly in step 3, no need to step 4.

At glance it seems to be related to Obsidian's cache of metadata - need to wait with clicking ribbon after syntax change for Obsidian to re-read the note.

2024-07-09_11-33-44
  • Sleep with the idea - is there any fix or workaround possible?
    • treating this as a minor, unavoidable issue

@SebastianMC SebastianMC merged commit fa6aafa into master Jul 10, 2024
2 checks passed
@SebastianMC SebastianMC deleted the 151-sort-notes-in-dd-mmm-yyyy-format branch July 10, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort notes in dd-Mmm-yyyy format
1 participant