Centralized all protoIds into ProtoIds
#1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a means of record keeping, aggregated all ProtoIds entries into a single object.
ml86
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
@DavidBakerEffendi I think an unstructured listing like it is now is fine. Otherwise you would now have to figure out the logical groups in which an ID needs to be unique. We also would need to maintain this grouping if we add new elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a means of record keeping, aggregated all ProtoIds entries into a single object.
Many items seem to collide, however they are often part of different schema objects.
To reviewers: Seems that uniqueness is a pair consisting of the ProtoId + Schema Object Type. E.g., ID + ConstantCategory or ID + Node, etc. One may choose to instead group the ProtoIds following this composite-style uniqueness instead of in a single object.