Capture test output for Minitest reporter #3286
Merged
+93
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
andyw8
force-pushed
the
andyw8/capture-test-output
branch
2 times, most recently
from
58964cd to
1cf3a07
Compare
andyw8
added
Severity: 4
andyw8
force-pushed
the
andyw8/capture-test-output
branch
2 times, most recently
from
48e8e63 to
4d7c5ea
Compare
andyw8
commented
Mar 10, 2025
vinistock
reviewed
Mar 17, 2025
vinistock
reviewed
Mar 18, 2025
andyw8
force-pushed
the
andyw8/capture-test-output
branch
from
46524c7 to
3fbcd9a
Compare
vinistock
reviewed
Mar 19, 2025
This was referenced Mar 19, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
### Motivation To go with #3286 Start handling the append output events. ### Implementation There's not much, we just need to register a new event and start appending the output. I also added a debug log.
Co-authored-by: Vinicius Stock <[email protected]>
Co-authored-by: Vinicius Stock <[email protected]>
vinistock
added a commit
that referenced
this pull request
Mar 19, 2025
Add support for appendOutput to streaming explorer updates (#3323) ### Motivation To go with #3286 Start handling the append output events. ### Implementation There's not much, we just need to register a new event and start appending the output. I also added a debug log. Co-authored-by: vinistock <[email protected]>
andyw8
force-pushed
the
andyw8/capture-test-output
branch
from
4119d83 to
774b7e2
Compare
vinistock
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intercepts anything sent to
stdoutviaputsorprintand emits is as event in the JSON stream. VS Code's test explorerappendOutputis not associated to any test ID, so we can just keep appending arbitrary output to that panel.One the approach is validated, I can do the same for test-unit.