Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate all T.let to RBS inline comments supported by Sorbet #3333

Merged
merged 5 commits into from
Mar 27, 2025

Conversation

Morriar
Copy link
Contributor

@Morriar Morriar commented Mar 19, 2025

Using spoom srb assertions translate all assertions like:

x = T.let(foo, String)

can be translated to:

x = foo #: String

and understood by Sorbet with the option --enable-experimental-rbs-assertions.

@Morriar Morriar added the chore Chore task label Mar 19, 2025
@Morriar Morriar self-assigned this Mar 19, 2025
@Morriar Morriar requested a review from a team as a code owner March 19, 2025 22:55
Copy link

graphite-app bot commented Mar 19, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

@andyw8 andyw8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool to see this progress!

Morriar added 5 commits March 26, 2025 16:53
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Using `spoom srb assertions translate`.

Signed-off-by: Alexandre Terrasa <[email protected]
Signed-off-by: Alexandre Terrasa <[email protected]>
@Morriar Morriar merged commit f596f38 into main Mar 27, 2025
45 checks passed
@Morriar Morriar deleted the at-rbs-let branch March 27, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants