Expand test directory command resolution with requires #3335
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
|
One hack I found is: |
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
…3336) ### Motivation I noticed that executing entire test directories through the explorer wasn't working. This is due to #3335 and the aspect that we were not automatically discovering the children of test files if they were never expanded. That meant that, we had no knowledge of their children existing, but when running the tests we are reporting results for those children we know nothing about. We need to automatically resolve children for test files that haven't been expanded otherwise the items we need to update don't exist. ### Implementation It's just a matter of invoking our resolve handler if there are no children in the test file item. ### Automated Tests Added a test.
vinistock
force-pushed
the
03-20-expand_test_directory_command_resolution_with_requires
branch
from
683a557 to
6dafa89
Compare
|
Yeah, I liked that. It makes the implementation simpler indeed. |
vinistock
force-pushed
the
03-20-expand_test_directory_command_resolution_with_requires
branch
from
6dafa89 to
ff0b173
Compare
vinistock
force-pushed
the
03-20-expand_test_directory_command_resolution_with_requires
branch
from
ff0b173 to
9e31b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our implementation of running all files in a directory was incorrect. You cannot use wildcards as part of the path because those are only expanded in the shell, not in a background command.
Implementation
To my surprise, running
ruby -Itest test/file1_test.rb test/file2_test.rbdoes not work. It consistently executes the first file and nothing else.The only way I found to execute a bunch of test files together is to run only one them and require the rest (lol). Like this:
If you know of another way to do this, please let me know. I couldn't find any alternatives that don't involve rake or other dependencies.
Automated Tests
Adapted our tests to verify the right command.