Handle changing visibility post method definition #3339
Merged
+67
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Graphite App
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
st0012
approved these changes
Mar 26, 2025
Merge activity
|
### Motivation I noticed we didn't handle changing method visibility post definition. This PR adds support for it. ### Implementation The idea is to check if there are string or symbol arguments being passed and then change the visibility of the methods passed. Otherwise, we continue doing the same as before. ### Automated Tests Added a test.
graphite-app
bot
force-pushed
the
03-21-handle_changing_visibility_post_method_definition
branch
from
dca4238 to
70d5b65
Compare
graphite-app
bot
deleted the
03-21-handle_changing_visibility_post_method_definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed we didn't handle changing method visibility post definition. This PR adds support for it.
Implementation
The idea is to check if there are string or symbol arguments being passed and then change the visibility of the methods passed.
Otherwise, we continue doing the same as before.
Automated Tests
Added a test.