Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): Fix global <body> styling and base fonts #9574

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

fix(frontend): Fix global <body> styling and base fonts #9574

wants to merge 6 commits into from
+51 −72

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Mar 5, 2025 •
edited
Loading

Base styling currently being fragmented between layout.tsx and globals.css is causing some styling (e.g. application background color) to be incorrectly overridden.

Changes 🏗️

  • Remove background color override from <body>
  • Move <body> classes from layout.tsx to globals.css
  • Remove background color from elements that shouldn't have their own background color
  • Remove font-neue, font-inter; replace by Geist (font-sans) where necessary

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Effective background color of application is #FEFEFE
    • Default font is Geist
    • Everything looks okay

@Pwuts
fix(frontend): Fix global <body> styling
a8dcbec 
- Remove background color override from `<body>`
- Move `<body>` classes from `layout.tsx` to `globals.css`
- Remove redundant `.font-neue` declaration in `globals.css`
@Pwuts Pwuts requested a review from a team as a code owner March 5, 2025 11:24
@Pwuts Pwuts requested review from ntindle and Swiftyos and removed request for a team March 5, 2025 11:24
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Mar 5, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 5, 2025 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 13ef8b0
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67c98632f59fb300075936dc

@github-actions github-actions bot added the size/m label Mar 5, 2025
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Mar 5, 2025 •
edited
Loading

Here's the code health analysis summary for commits 231775f..13ef8b0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
❗ 28 occurences introduced
🎯 11 occurences resolved
View Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@netlify Netlify
Copy link

netlify bot commented Mar 5, 2025 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 13ef8b0
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67c9863291f7710008420f55

ntindle
ntindle previously approved these changes Mar 6, 2025
View reviewed changes
@github-actions github-actions bot added size/l and removed size/m labels Mar 6, 2025
@Pwuts Pwuts changed the title fix(frontend): Fix global <body> styling fix(frontend): Fix global <body> styling and base fonts Mar 6, 2025
@Pwuts
remove Inter and PP Neue Montreal, use Geist instead; remove redundan…
13ef8b0 
…t and non-functional `font-geist` references
@Pwuts Pwuts force-pushed the pwuts/fix-app-global-styling branch from 20bf0dc to 13ef8b0 Compare March 6, 2025 11:25
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Mar 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle left review comments

@Swiftyos Swiftyos Awaiting requested review from Swiftyos Swiftyos is a code owner automatically assigned from Significant-Gravitas/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
conflicts Automatically applied to PRs with merge conflicts platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/l
Projects
AutoGPT development kanban
Status: 👍🏼 Mergeable
Frontend
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pwuts @ntindle