fix(backend): Move Notification service to DB manager #9626
+87
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR shows concerning changes in get_graph_executions where the user_id parameter is made optional without explanation of how this would be protected from unauthorized access. While the changes themselves seem well organized (moving DB operations to the DB manager), this security implication needs to be addressed. Additionally, the PR template is not filled out properly - missing test plan and clear listing of changes. |
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
|
Here's the code health analysis summary for commits Analysis Summary
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
ntindle
approved these changes
Mar 13, 2025
majdyz
added a commit
that referenced
this pull request
Mar 13, 2025
DatabaseManager is already provisioned in RestApiService, and NotificationService lives within the same instance as the Rest Server. ### Changes 🏗️ Moving the DB calls of NotificationService to DatabaseManager. ### Checklist 📋 #### For code changes: - [ ] I have clearly listed my changes in the PR description - [ ] I have made a test plan - [ ] I have tested my changes according to the test plan: <!-- Put your test plan here: --> - [ ] ... <details> <summary>Example test plan</summary> - [ ] Create from scratch and execute an agent with at least 3 blocks - [ ] Import an agent from file upload, and confirm it executes correctly - [ ] Upload agent to marketplace - [ ] Import an agent from marketplace and confirm it executes correctly - [ ] Edit an agent from monitor, and confirm it executes correctly </details> #### For configuration changes: - [ ] `.env.example` is updated or already compatible with my changes - [ ] `docker-compose.yml` is updated or already compatible with my changes - [ ] I have included a list of my configuration changes in the PR description (under **Changes**) <details> <summary>Examples of configuration changes</summary> - Changing ports - Adding new services that need to communicate with each other - Secrets or environment variable changes - New or infrastructure changes such as databases </details> (cherry picked from commit f4d4bb8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseManager is already provisioned in RestApiService, and NotificationService lives within the same instance as the Rest Server.
Changes 🏗️
Moving the DB calls of NotificationService to DatabaseManager.
Checklist 📋
For code changes:
Example test plan
For configuration changes:
.env.exampleis updated or already compatible with my changesdocker-compose.ymlis updated or already compatible with my changesExamples of configuration changes