Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flutter3 warnings #216

Merged

Conversation

P-B1101
Copy link
Contributor

@P-B1101 P-B1101 commented May 16, 2022

just run dart fix --apply

@VB10
Copy link

VB10 commented May 16, 2022

cool @P-B1101 thanks.

Copy link

@ariefwijaya ariefwijaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@shashikantdurge shashikantdurge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudhi001
Copy link

Screenshot 2022-05-26 at 10 10 16 AM

Custom radius functionality removed

@P-B1101 P-B1101 force-pushed the flutter3_compatibility branch from ba893d9 to 3c1f127 Compare June 2, 2022 20:09
@vatsaltanna vatsaltanna linked an issue Jun 2, 2022 that may be closed by this pull request
@vatsaltanna vatsaltanna merged commit 31989fa into SimformSolutionsPvtLtd:master Jun 2, 2022
@BirjuVachhani
Copy link
Contributor

Since this PR had changes that are only available in Flutter 3. it will fail for versions before that because min flutter version constraint is not specified in pubspec.yaml

flutter: '>=3.0.0'

@BirjuVachhani
Copy link
Contributor

@vatsaltanna Here's a PR for it.

#224

@P-B1101 P-B1101 deleted the flutter3_compatibility branch June 3, 2022 10:26
vatsaltanna added a commit that referenced this pull request Aug 21, 2022
vatsaltanna added a commit that referenced this pull request Aug 21, 2022
vatsaltanna added a commit that referenced this pull request Aug 22, 2022
vatsaltanna added a commit that referenced this pull request Aug 22, 2022
vatsaltanna added a commit that referenced this pull request Aug 22, 2022
vatsaltanna added a commit that referenced this pull request Aug 22, 2022
DhavalRKansara pushed a commit that referenced this pull request Aug 22, 2022
vatsaltanna added a commit that referenced this pull request Aug 22, 2022
vatsaltanna added a commit that referenced this pull request Aug 22, 2022
DhavalRKansara pushed a commit that referenced this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when upgrading Flutter to version 3
7 participants