Showcase description alignment #292
Conversation
|
Hi @Abu-muhab , Thanks for contributing to this package. I see that this PR includes two different functionalities 1. text alignment and 2. text computation. can you please create a PR which includes only text alignment changes. |
|
Thanks @vatsaltanna-simformsolutions. I have reverted the text computation changes on this PR. I have opened a separate PR for that here https://github.com/SimformSolutionsPvtLtd/flutter_showcaseview/pull/293/files |
lib/src/showcase.dart
Outdated
| @@ -63,6 +63,7 @@ class Showcase extends StatefulWidget { | |||
| final VoidCallback? onTargetDoubleTap; | |||
| final VoidCallback? onTargetLongPress; | |||
| final BorderRadius? tipBorderRadius; | |||
| final ShowcaseDecriptionAlignment descriptionAlignment; | |||
There was a problem hiding this comment.
please use TextAlign type instead of creating separate type.
There was a problem hiding this comment.
Pushed new changes
There was a problem hiding this comment.
Thanks, Can you please add the same changes for the title too ? Also please squash all the commits.
There was a problem hiding this comment.
Not sure what you mean. The variable descriptionAlignment should be renamed to textAlign?
There was a problem hiding this comment.
nope, It's perfect. can you please create the same configuration for title too? titleAlignment
There was a problem hiding this comment.
Highly appreciate it. Thanks!
There was a problem hiding this comment.
please make sure to squash all the commits as there are more than 10 commits have been created for this feature.
There was a problem hiding this comment.
@vatsaltanna Commits squashed and changes pushed for titleAlignment
chore: naming fix feat: showcase description alignment fix: use TextAlign to align text fix: set default description alignment to left chore: make descriptionAlignment optional chore: revert width computation changes fix: use TextAlign instead of custom alignment type chore: clean up feat: title alignment
Abu-muhab
force-pushed
the
feat/showcase-description-alignment
branch
from
b9f0f68 to
aed9e76
Compare
|
Hi @Abu-muhab , This PR has been merged and changes will be available to user in next release. Thank you very much for your contrubution to this wornderfull package. |
|
Thank you @vatsaltanna-simformsolutions. |
feat: title and description alignment (SimformSolutionsPvtLtd#292)
Added
ShowcaseDecriptionAlignmenttoShowcasein relation to this issue: #253