fix!: 💥Parameter changes of the Showcase and ShowCaseWidget class
#296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsaltanna
reviewed
Oct 28, 2022
| @@ -67,13 +67,13 @@ Showcase( | |||
| titleAlignment: TextAlign.start, | |||
There was a problem hiding this comment.
add seprate section of breaking changes
|
Currently, PR title validation workflow not merged so it will not check title but from my side I am suggesting this. fix: 💥Parameter changes of the |
|
If you are mentioning the class name anywhere(description, title, commit message), use |
HappyMakadiyaS
force-pushed
the
fix/parameter-changes
branch
from
fe2d20c to
8aa6d02
Compare
HappyMakadiyaS
changed the title
HappyMakadiyaS
changed the title
Showcase and ShowCaseWidget class
HappyMakadiyaS
changed the title
Showcase and ShowCaseWidget classShowcase and ShowCaseWidget class
HappyMakadiyaS
force-pushed
the
fix/parameter-changes
branch
from
8aa6d02 to
93d5259
Compare
mobile-simformsolutions
changed the title
Showcase and ShowCaseWidget classShowcase and ShowCaseWidget class
vatsaltanna
reviewed
Nov 1, 2022
README.md
Outdated
| <tr><td>tipBorderRadius</td><td>tooltipBorderRadius</td></tr> | ||
| </table> | ||
|
|
||
| Unused parameters of `Showcase.withWidget()` which are not impacting view of showcase widget that has been removed from parameter list of the named constructor `Showcase.withWidget()`. |
There was a problem hiding this comment.
Unused parameters of Showcase.withWidget() which do not impact the UI of showcase have been removed from the parameter list of the named constructor Showcase.withWidget().
HappyMakadiyaS
force-pushed
the
fix/parameter-changes
branch
2 times, most recently
from
aea45fe to
9848050
Compare
HappyMakadiyaS
changed the title
Showcase and ShowCaseWidget classShowcase and ShowCaseWidget class
HappyMakadiyaS
force-pushed
the
fix/parameter-changes
branch
from
9848050 to
590adab
Compare
vatsaltanna
approved these changes
Nov 2, 2022
HappyMakadiyaS
force-pushed
the
fix/parameter-changes
branch
from
590adab to
1629616
Compare
HappyMakadiyaS
force-pushed
the
fix/parameter-changes
branch
from
1629616 to
bc53c45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consist changes of parameter names in Showcase and ShowcaseWidget class.
Showcase class parameter:
ShowCaseWidget class parameter:
Some of the parameter of Showcase.withWidget() has been moved from parameter list to initializer list which are
title, description, titleAlignment, descriptionAlignment, titleTextStyle, descTextStyle, tooltipBackgroudColor, textColor, tooltipBorderRadius, tooltipPadding
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?