fix: Use maybeOf(context) instead of of(context) in order to check null value #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
requested changes
Feb 21, 2023
| final showCaseContext = ShowCaseWidget.of(context).context; | ||
| if (mounted) { | ||
| if (Overlay.maybeOf(showCaseContext) != null) { | ||
| Overlay.of(showCaseContext)!.insert(overlayEntry); |
There was a problem hiding this comment.
As you are using maybeOf so please also use it here. It will also fix the linting error.
| Overlay.of(showCaseContext)!.insert(overlayEntry); | ||
| } else { | ||
| if (Overlay.maybeOf(context) != null) { | ||
| Overlay.of(context)!.insert(overlayEntry); |
There was a problem hiding this comment.
Same here.
|
Build is failing due to 2 linting issue. Fixing comments will fix one of linting issue. Other issue is unrelated to file changes. |
|
Closing this PR as this issue has already been fixed in PR: #288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the new flutter version 3.7 and above the call to Overlay.of(showCaseContext) throws an hard error on null value which breaks the previous behaviour. Instead make use of the maybeOf which returns null if no value is given.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #330