-
Notifications
You must be signed in to change notification settings - Fork 26
Bump fmt version requirement to 11.1.0 #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
83dccb2
to
f47b0c1
Compare
f47b0c1
to
62aa007
Compare
Hum, it won't be possible to bump the minimum fmt to 11 due to dependency constraints (mainly, our friendly neighborhood ROS, is that right @edantec ?) On our end we are building with Do you think there might be another solution? An include or line of code to change? |
On my end I can't test with |
Can you try building manually with conda ? Our Ros environments with 10.2.1 use conda. |
Hello @abussy-aldebaran, I have no issue building bench-talos-walk with pixi in the all environment (and fmt 11.0.2). @ManifoldFR btw, building in the default environment is broken because of some coal symbols |
The proxsuite-nlp The fmt package declare it doesn't break his ABI on patch release: https://github.com/conda-forge/fmt-feedstock/blob/main/recipe/meta.yaml#L14 So you can change the patch version, but to change the major.minor we need a rebuild from conda-forge. |
I couldn't reproduce it when building from scratch either. Maybe my |
Ok, be careful when using pixi to not modify the pixi environment with conda. I saw some people (:eyes: @ManifoldFR) doing that, and it create a non reproducible environment. I think we can close this PR ? |
I think so yes @jorisv |
When building
bench-talos-walk
withpixi
, I got the errorld: lib/libaligator.so.0.11.0: undefined reference to `fmt::v11::detail::vformat_to(fmt::v11::detail::buffer<char>&, fmt::v11::basic_string_view<char>, fmt::v11::basic_format_args<fmt::v11::context>, fmt::v11::detail::locale_ref)
I had
fmt 11.0.2
selected bypixi
. Indeed, when buildingfmt
at this version, I gotWhen building
fmt
at master, I gotwhich is the correct output.
Running a
git bisect
identified fmtlib/fmt@c3344e2 as the fixing commit.Therefore, I propose to update the
fmt
requirement to version11.1.0