minor adjustments #252
Open
minor adjustments #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@poojaSprophecy this is great! Very easy to read. I noticed just a couple items:
on the first image, we see Basic Info, Providers setup, and Secrets. But later, Secrets are replaced by Connections. Is this a bug? Maybe for the docs you want to replace Secrets with Connections while the product is in progress to fix? I added some related text, which should be adjusted depending on your decision here.
It seems like an image is missing related to this text: "Provide a (1)role name and optionally provide a (2)description. (3)Edit the trusted Select trusted entities Json"
I updated the last line, but I'm not sure if it's correct as I'm not hands-on with airflow.
"Please make sure you select the Fabric for the same Snowflake environment which has the desired connection in your Airflow."