Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BpkSwitch] Adjust focus behaviour #3737

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

gert-janvercauteren
Copy link
Contributor

@gert-janvercauteren gert-janvercauteren commented Feb 12, 2025

BpkSwitch

We noticed the focus ring around the BpkSwitch component doesn't follow the component outline. There was also inconsistent behaviour when clicking the component, sporadically showing the focus ring.

This PR adjusts the focus ring visual style and ensures it will show up when focusing by keyboard navigation only

Before After
image image

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@gert-janvercauteren gert-janvercauteren added the patch Patch production bug label Feb 12, 2025
@gert-janvercauteren gert-janvercauteren self-assigned this Feb 12, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3737 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3737 to see this build running in a browser.

@olliecurtis olliecurtis merged commit b2d1af2 into main Feb 12, 2025
8 checks passed
@olliecurtis olliecurtis deleted the acc/ACC-258_switch_focus_behaviour branch February 12, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants