Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-JIRA][BpkChipGroup] Fix chip alignment with leading icons #3764

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

bjoern-wahle
Copy link
Contributor

See slack thread.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

…s it breaks alignment if any chip has an icon
@bjoern-wahle bjoern-wahle added the minor Non breaking change label Mar 4, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3764 to see this build running in a browser.

@bjoern-wahle bjoern-wahle changed the title [NO-JIRA][BpkChipGroup] Remove align-items: baseline; on chip group as it breaks alignment if any chip has an icon [NO-JIRA][BpkChipGroup] Fix chip alignment with leading icons Mar 4, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3764 to see this build running in a browser.

@arnaugm arnaugm merged commit 29b878d into main Mar 4, 2025
8 checks passed
@arnaugm arnaugm deleted the NO-JIRA_bpk-chip-group-icon-alignment branch March 4, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants