-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables a tracker to forward log messages to the server, and the server to send the log messages to the UI. #1234
base: main
Are you sure you want to change the base?
Conversation
…er to send the log messages to the UI. 1. `PROTOCOL_LOG_SUPPORT` which determines if the server supports forwarding log messages 2. `PACKET_LOG (26)` which is the UDP packet that the tracker sends to the server 3. `Device.logMessages` which is the new field for the UI to receive log messages
It is cool, i mostly dont like how it looks. I would create another block below the tracker settings with a nice title And put the logs text behind a darker color. Similar to the actual serial console in the server. |
From the look of the code it also looks like all trackers will be sending their logs to the server no matter what. Imo this is not good. The server should only send the logs through the solarxr protocol when needed. You would need a packet to Start listening for logs from the gui and stop listening. Also that pose another question. Should the server really be always listening for tracker logs without asking for it. this seem like a lot of packets for a debug feature. |
agree, @loucass003 |
Tracker -> Server Server -> UI |
I imagine this will simplify debugging problems for customers. It could be super useful for things like calibration. It may lead firmware to put in more logs, e.g. so that customers can figure out why a tracker's acting weird. |
@jabberrock yeah |
PROTOCOL_LOG_SUPPORT
which determines if the server supports forwarding log messagesPACKET_LOG (26)
which is the UDP packet that the tracker sends to the serverDevice.logMessages
which is the new field for the UI to receive log messagesDevice logs are displayed in the GUI under the specified tracker, because there is no place to put device-specific information, nor is there a good way to separate tracker-specific logs from each other. This means that aux trackers will show the same device logs as the main tracker.
Related PRs:
SlimeVR/SolarXR-Protocol#153
SlimeVR/SlimeVR-Tracker-ESP#361
2024-11-11.12-43-26-00.00.29.546-00.00.48.967.mp4