Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Resume last played song #484

Closed
LoreGas opened this issue Jan 11, 2016 · 7 comments
Closed

[Feature] Resume last played song #484

LoreGas opened this issue Jan 11, 2016 · 7 comments
Assignees

Comments

@LoreGas
Copy link

LoreGas commented Jan 11, 2016

In my opinion it would be cool to save the song and minute that you are playing so that when you open the app again it will resume from where you left

@edisonchee
Copy link

Seems trivial. The SoundCloud track resource is a JSON object which has track duration attribute, of which the app is already making use of.

@weblancaster
Copy link
Member

Feel free to work on it @edisonchee

@christopherturner
Copy link

This would be nice; looking forward to seeing it implemented.

@edisonchee
Copy link

@weblancaster I've given this a go, 2448efd. I've only tested it on OSX; if anyone could test it on Linux or Windows that'd be great. Maybe @LoreGas or @christopherturner can help?

@LoreGas
Copy link
Author

LoreGas commented Jan 29, 2016

Is this in the new version or where can I download to test?

@edisonchee
Copy link

If you're familiar with git, you can add my fork as a remote and merge with a branch from your own fork. Otherwise, give me some time to test it on Linux and Windows and hopefully I can do a PR for this feature.

@weblancaster
Copy link
Member

Nice work @edisonchee can you open a PR though? and besides descriptive title also put closes #484 on the title.. thanks

@weblancaster weblancaster self-assigned this Feb 3, 2016
weblancaster added a commit that referenced this issue Feb 3, 2016
merge conflict, resume last played track and position, Closes #484, closes #565, closes #576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants