[Enhancement] use zap as logger #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yandongxiao
force-pushed
the
feature/use-controller-runtime-zap-log2
branch
from
e17c583 to
3a875fb
Compare
Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
feature/use-controller-runtime-zap-log2
branch
from
3a875fb to
d07026d
Compare
kevincai
approved these changes
Dec 6, 2023
Comment on lines
+185
to
+186
| - --zap-time-encoding iso8601 | ||
| - --zap-encoder console |
There was a problem hiding this comment.
@yandongxiao These parameters are broken.. If I try to install the operator using this deploy/operator.yaml file, I am receiving this error:
kubectl logs kube-starrocks-operator-b49c6d4fc-sljzj -f -p
flag provided but not defined: -zap-time-encoding iso8601
Usage of /sroperator:To have success to install the operator, I need to remove the both lines:
- --zap-time-encoding iso8601
- --zap-encoderThere was a problem hiding this comment.
Thanks, I will try to fix it.
There was a problem hiding this comment.
I Have fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #342