Issue401/expose security capabilities #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingmxu
force-pushed
the
issue401/expose_security_capabilities
branch
from
61ebc25 to
adf6341
Compare
|
should alose expose security capabilities in helm chart |
|
Right, I’ll submit another PR after this one is cleared. |
yandongxiao
reviewed
Jan 18, 2024
mingmxu
force-pushed
the
issue401/expose_security_capabilities
branch
2 times, most recently
from
6690c5e to
ea5f71c
Compare
Signed-off-by: Mingmin Xu <[email protected]> use a short name for Capabilities Signed-off-by: Mingmin Xu <[email protected]> add more unit tests Signed-off-by: Mingmin Xu <[email protected]> fix lint error and json:"Capabilities,omitempty" Signed-off-by: Mingmin Xu <[email protected]> run make manifests and make generate Signed-off-by: Mingmin Xu <[email protected]> fix format error Signed-off-by: Mingmin Xu <[email protected]>
mingmxu
force-pushed
the
issue401/expose_security_capabilities
branch
from
ea5f71c to
24779fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the function required by Issue-401.
It expose
CapabilitiesinStarRocksComponentSpecwhich is required for Datadog profiling integration. Some unit tests are added to verify it.cc @yandongxiao